search

drachels / moodle-mod_mootyper

4 stars 18 forks source link

german layout v4 switches ö from "finger 4" to normal #109

Open andreasschenkel opened 1 year ago

andreasschenkel commented 1 year ago

After pushing the 'ö' in german layout v4 the color of the ö is not light red any more. It should be the same color like 'a'.

grafik

Reason: code switches the class from "finger4" to "normal"

grafik

drachels commented 1 year ago

Yes, I see the same error. The reason is there was no German layout of any kind when I took over the responsibility for MooTyper. I had started development on German(V4) and some others, when I realized the Shift keys were not working correctly. Anytime there was a shifted letter, both shift keys were being highlighted. That is when I created the English(V5) version and started developing V5 versions of all the other keyboard layouts.

Somewhere about MooTyper v3.5.3, I released the first German(V4) and did not realize that when I upgraded it to version 4.1, it had this bug in it. Sometime shortly thereafter, I was given a copy of a German layout that used icons, instead of words, for Enter, tab, etc., and switched to it

Anyway, I quit working on all the V4 files, and unfortunately, during my wife's illness, I accidentally included some of them again.

If you truly want to use a V4 layout, get a copy of the German(V4).js file from MooTyper v3.5.3, and use it, instead of the v4.1 js file. Otherwise, I would just use the German(V5)-icons layout. If you would like, I can create a German(V5) layout that uses words, instead of icons, but I do not plan to include any V4 layouts, in future releases.

andreasschenkel commented 1 year ago

To get the most flexibility a German(V5) Layout would be great so that future releases could use this layout as default.

drachels commented 1 year ago

I will try to get it done in the next few days. Truthfully, I am feeling just miserable. I had major dental surgery last Tuesday, which is still giving me a significant amount of pain, which just kills my concentration and desire to do any computer work. Old age eye problems are also creeping up on me (dry eye) and making screen time a real bother.

andreasschenkel commented 1 year ago

It is not so important!

drachels commented 1 year ago

Sitting in my TV chair seems to aggravate my dry eye problem, so I made myself stay upright, and while doing so, felt I should work on this. I think I have a working German(V5) located here. https://www.drachels.com/moodle311/mod/mootyper/view.php?id=133 Log in directions are on the login page. Let me know if it needs something further. The sample lesson I have it set for, does not include the <> keys, as I don't currently have the right keyboard installed and cannot type them when I am using the German keyboard driver on my computer.

drachels commented 1 year ago

Forgot to mention, the two new files are there in a folder and will let you down load them to add them to your Moodle site. Stick the two files in the ..youmoodle/mootyper/layouts, folder and and then run the Import lesson / KB layout tool, to make the new layout available.