search

drachels / moodle-mod_mootyper

4 stars 18 forks source link

Bug: Accent letters not working in German layout #115

Open PhMemmel opened 10 months ago

PhMemmel commented 10 months ago

Reproduction step:

drachels commented 10 months ago

While doing some testing of the merged code, I notice that there were a few other errors that need to be fixed. It was back in July of 2018 when the German(V4) layout was created by me at the request of someone. The German(V5)-icons was donated and included in the MooTyper v3.8.1 on December 7, 2019. The German(V5) layout was finally added to MooTyper v4.2.2 back in January of this year, I think.

I have just today realized that an error in the V4 files, is also in the V5 file. The .js file includes references to, this.umlaut, in four places and to, 'jkeyumlaut', in two places. After comparing to my reference pictures for the keyboard layout design, I realized that there is NO umlaut in the keyboard.AND there is no, ëïËÏ, characters.

I will spend some more time on this and see what I can come up with.

I also note that here, in this issue, you reference German(V5)-icons.js, but your pull request merged to the German(V5).js file. They will both need to be fixed and I will need to take a look at the GermanWKeypad(V6)-icons.js and the German(SwissV5).js files, just in case they need some fixes too.

PhMemmel commented 10 months ago

Great to hear, thank you so much for the time and effort!

drachels commented 10 months ago

Just pushed changes for German(V5) and German(V5)-icons plus some other fixes, to the master branch. I have also created a new version of the MOODLE_424_STABLE branch and a release version for testing.

I know that both keyboard layouts will now type, "ê é è", if they are included in an exercise, but I have not had the chance to try the whole layout just yet with a lesson that includes a comprehensive set of exercises to test all the other keystrokes and shifts. I would appreciate it if you can test and let me know if there is anything else in the layouts that needs to be fixed.

It has been 45 years since I was last stationed in Germany and I have completely lost what little skill I had with the language so it is very easy for me to miss things when trouble shooting a foreign language keyboard layout. It really gets difficult when I am working on some language with an alphabet that looks totally different. For instance, it has just now taken me two hours to get the shift keys to work for changing the Arabic(v4)dual layout over to a new, Arabic(ARV5)dual, version.

Thanks for any help you can give, and I will spend some more time on it, too.

PhMemmel commented 10 months ago

Great, thank you so much for your fast response and work. We will try to provide our users with your changes as fast as possible and will report any problems to you, if there are still some!

drachels commented 10 months ago

While the layout changes are okay, I have found a couple of bugs in attrem.php, gview.php, and maybe inlessons.php. So, I have temporarily removed the MOODLE_424_STABLE branch. I am testing fixes right now and plan to push code changes tomorrow on October 31.