search

drachels / moodle-mod_mootyper

4 stars 18 forks source link

Moodle Coding Guidelines #64

Closed tholudwig closed 5 years ago

tholudwig commented 5 years ago

Hi,

In the translation of mooytper and the inclusion in our Moodle instance, we should check all new plugins for compliance with the Moodle coding guidelines. For this we use the plugin codechecker.

That has thrown a few small mistakes. These are mainly capital letters (NULL -> null) or unnecessary spaces and inline comments.

Only in the atchk.php should two safety-relevant aspects be listed.

If you want, you can apply the appropriate changes.

drachels commented 5 years ago

Finally had a chance to do some work between chemo days. Fixed many of the code style errors that have crept into the keyboard layouts. One that was in about a dozen layouts, is actually caused by a bug in the codechecker plugin, but I discovered a place to put the offending character so that the codechecker no longer gets "confused" and spitz out errors. Fixed a couple of missing/broken characters in the new German(V4) layout. Also removed a couple of characters from it that were not needed.

drachels commented 5 years ago

Fix included in release 3.5.4.