search

drachels / moodle-mod_mootyper

4 stars 18 forks source link

68: fixing issues showing charts using comma-serperated language #69

Closed tholudwig closed 5 years ago

tholudwig commented 5 years ago

Hi drachels,

due to my changes, the variables are no longer converted to comma-seperated notation with format_float. As a result, the charts are displayed correctly. Only hovering over the charts still shows point-seperated notation. But this needs deeper changings in moodle chart api, I think!

When displaying the results in the tables, I added the transformation to a variable. Now all variables should be displayed correctly, according to the language you've chosen.

drachels commented 5 years ago

Tomorrow will finish this go-round of chemo. I will try to test and merge when the wife is feeling better. Usually takes about five days. Thanks for finding this problem and providing a fix.

drachels commented 5 years ago

Recommended changes were done manually and are in current code.