Safari&Mac

[pmaneggia]

Hi! We experienced a problem with Safari on a Mac. I can add the activity, but when I do the setup I can not save the configuration and move forward (see screenshot, sorry it is in german, but I hope one can still follow). It does not seem to depend on the theme (here on the screenshot: clean). Our platform is based on moodle 3.5 and we used mootyper branch MOODLE_354+_STABLE. Chrome on Mac works as expected.

[drachels]

The problem has nothing to do with your Moodle or MooTyper, but is due to Safari NOT responding to an onClick event. (The confirm button.)

I usually use W3 Schools for reference and their site says Safari does recognize onClick, however, it does not seem to do so. In this case for MooTyper 3.5.4+ the onClick event for the button is in file mod_setup.php, line 415. Change line 415 from this: $htmlout .= '
'; TO THIS: $htmlout .= '
';

One thing that you may not realize, I go to a LOT of extra time and effort to make sure that the LATEST version of MooTyper works for ANY Moodle from version 2.7 to the just released 3.8.0. There are a lot of NEW things added to MooTyper since version 3.5.4+, so you really should upgrade to MooTyper 3.8.0. If you DO UPGRADE, the line to change is 448.

If you do not want to change the code, but do want to upgrade, I will have a fixed MooTyper 3.8.0+ available in a few minutes from now.

[pmaneggia]

Many thanks! The reason why we cannot update so easily is, we have a rather large custom moodle, but we will undo the changes and update asap.

[drachels]

Sorry, my wife was asking me to do something and I did not look at my entry after saving it, and did not realize the important part of the post was filtered out. Since MooTyper 3.8.0+ is compatible with any Moodle from 2.7 to 3.8, you should just use it. Doing so will fix your Safari problem, plus give you access to all the NEW stuff that is in MooTyper now. If you must continue to use MooTyper 3.5.4+, in mod_setup.php replace line 415 with 449 from the same file in MooTyper 3.8.0+.

[pmaneggia]

Many thanks, I had found the line in your code straight away after thinking a second :-)

[drachels]

By the way, I see that it looks like you are using a modified version of the German(V4) keyboard layout since in your picture, what you are using is named German(V4)-icons. May I ask, what is the difference? Is it something you would like added to the version I ship in the plugin?

Would you be interested in a German(V5) layout? The difference is the way the shift keys work. In V4, they both get highlighted for a capital letter. In V5 layouts they are separate. The left shift is highlighted for keys on the right side of the layout, and the right shift is highlighted for keys on the left side of the layout. In version V6 layout, I also include the number keypad.

[pmaneggia]

Hi, sorry I did not answer for a whole week! Yes, we would be interested in a German(V5) keyboard layout and yes, my colleague changed a bit the layout to show icons on the keys like shift instead of text. I send you the file. I also send you a pull request of another little change we made, but maybe I need to that tomorrow.

[drachels]

Just pushed a German(V5)-icons layout to master branch. It passed my first all keys test, but I will check it some more tomorrow. Might need to make minor width adjustments of some of the bottom row keys, as they sometimes render slightly oversize in some browser/theme combinations. Don't have more time for it today.

I would appreciate it if you would give it a try and let me know about anything that needs to be done.

I noticed you left off the color coding for a couple of what I call, 'type first' keys, so I left them that way as I am sure that actual keyboards do not use red letters for ^ , ` , etc. Those colors are usually more useful when teaching very young kids to type, but I do not know what age you students are.

[drachels]

Necessary changes have been incorporated in latest versions.