drachels / moodle-mod_mootyper

4 stars 18 forks source link

Ratings permission inside the module activity #85

Closed will-bulluck closed 1 year ago

will-bulluck commented 4 years ago

We have run into an issue where when we go to edit the rating on the individual module activity in Moodle 3.7 we cannot edit the selection from "No Rating" to anything else. The option above it says "Roles with permission to rate" but we have no options to view the capability in the permissions for any role.

Steps to Replicate

  1. Create a MooTyper activity in Moodle.
  2. Edit the settings for the activity.
  3. Under the rating option change "No Rating" to anything else.
  4. Save changes.
  5. Edit settings again to see the ratings have not changed from "No Ratings".
drachels commented 4 years ago

This is caused by the same thing as issue #83. Suggest you upgrade to the latest MooTyper until I have a chance to finish integrating the grade system in MooTyper to work with Moodle grades.

will-bulluck commented 4 years ago

Hey there!

Thanks for getting back to me, we are on the current most build you have on moodle.org 2019123002 and it is still an issue.

Thanks,

Will

drachels commented 4 years ago

If you read the April 24 entry I made for issue#83, you will see that Rating was incorrectly enabled and the next entry from April 25 tells you how to turn it off, until I can come out with a new MooTyper version. Normally, I create MooTyper activities and ONLY add a Name and Description, Open time and Close time, the click Save and display. On the following page that appears, I click, Setup, and set all the options there. I am currently working daily on the next MooTyper, which has lots of new navigation buttons, and I have a bug I've been trying to fix for the past three days with no luck. For health reasons, I currently limit my computer time to a maximum of 5 hours a day, so it is going slowly, but I will try to get out a new version soon.

will-bulluck commented 4 years ago

Understood and thanks!

drachels commented 4 years ago

Hi Will, Sorry I have not got to Ratings yet. Over the past four days I have gotten Groups working, but haven't released it yet as it is giving me problems with the graphing. Along with Groups, this release candidate has a lot of other updates, most notable is navigation via buttons. You can check it out at: http://m3x.drachels.com/course/view.php?id=4 Let me know if you would like teacher access.

will-bulluck commented 4 years ago

Hey @drachels yes, I think I would need teacher access to check.

username wbulluck

drachels commented 4 years ago

Sorry to be so slow to reply. Had dental cleaning appointment and shopping and just got back to work. You are now enrolled as a teacher in the course at: http://m3x.drachels.com/course/view.php?id=4 In the time since my last post 9 days ago, I have released a new MooTyper 3.9.0 that implements groups and a lot of other changes. In fact, on the above linked m3x site I have already posted code for a v3.9.0+ version.

will-bulluck commented 4 years ago

@drachels Thanks for that! It seems as though I cannot access what I am looking to change the grade to ratings.

drachels commented 4 years ago

That's correct. Current MooTyper uses it's own internal grading and has way of using ratings at the moment. As mentioned before, it is on my list of things to be added.

will-bulluck commented 4 years ago

Hello @drachels

I hope you are well! Any update on this?

Will

drachels commented 4 years ago

Hi Will It's still on my list of things to be added, when I get the time. My wife's cancer has come back and for the past two weeks we have been scrambling to get her back into chemotherapy. Had surgery Monday to put in a new Groshong port for that, and just finished the first two day cycle of chemo that took 4 hours on Tuesday, and then she wore a pump that administered a dose over the next 46 hours. Just got home from having the pump removed. We get to go do another two day cycle starting on August 4.

I have been working on adding the rating system, first, to a new Diary plugin I am developing. I've been hoping to get it to work but there is very little developer documentation on what to add and where to add it. Essentially the docs say to look at the lib.php file for forum, questionnaire, and database activity, which means I have to go and decode what's there and compare to the example code, and then try to figure out how to adapt it to MooTyper. Each of those seem to have functions that are not in the examples, so have to figure them out too. To say the least, it is going a lot slower than I had hoped.

Sadly, the amount of time I can work on this each day, depends directly on my wife's nausea and diarrhea.

will-bulluck commented 4 years ago

@drachels Understood, Sorry to hear of your wife's cancer. I will be praying for you and her to have a speedy recovery.

Take care.

drachels commented 4 years ago

Just installed MooTyper 3.9.2 at http://m3x.drachels.com/ It has some new features, and the start of grade development. See the site announcements for more info.

drachels commented 4 years ago

Had to add one more db field, grade_mootyper, to the db table, mootyper. Also a couple of other small additions to file, gcnext.php, so I have created a new branch, MOODLE_392_BETA, and installed it at, http://m3x.drachels.com/ It needs more testing, but it does add a students latest exercise grade to the Moodle grade book. So, I'm getting there. Current code could be used for MooTyper exams, I think.

drachels commented 4 years ago

Just to let you know that I have MooTyper working with Moodle Grade and Rating now. Still have to add the code to "remove" the grade and rating when anyone deletes any grade in any MooTyper. Not being able to delete can cause reported ratings to not be correct. Hope to have the delete working soon. Code is in the current MOODLE_392_BETA branch.

drachels commented 4 years ago

Deleting a grade entry in MooTyper now deletes the corresponding entry in the mdl_rating table and the code is included in MOODLE_392_BETA branch.

will-bulluck commented 4 years ago

@drachels Thanks for the updates! I am testing now

drachels commented 4 years ago

Sorry, I fogot to post about it here, I have installed latest MooTyper for testing at http://m3x.drachels.com/course/view.php?id=4

drachels commented 1 year ago

This issue was fixed as part of MooTYper 3.9.2.