search

drachtio / drachtio-freeswitch-modules

A collection of open-sourced freeswitch modules that I use in various drachtio applications
MIT License
169 stars 114 forks source link

Fix buffer overflow in SimpleBuffer #118

Closed pragmatrix closed 11 months ago

pragmatrix commented 1 year ago

Hi, we are planning to use the google transcribe module and are in the process of reviewing the code. One thing that I've found is a potential buffer overflow in the SimpleBuffer. May be you can take a look.

davehorton commented 1 year ago

Thanks, will have a look!

davehorton commented 1 year ago

@xquanluu can you also have a look?

xquanluu commented 1 year ago

Hi @davehorton that's correct fix, when memcpy, need to copy with m_chunkSize length instead of datalength.