search

drachtio / drachtio-freeswitch-modules

A collection of open-sourced freeswitch modules that I use in various drachtio applications
MIT License
171 stars 119 forks source link

Possibly incorrect documentation #71

Closed egorsmkv closed 2 years ago

egorsmkv commented 2 years ago

The page https://github.com/drachtio/drachtio-freeswitch-modules/tree/main/modules/mod_audio_fork says

The audioContentType value can be either wave or raw.

when I set audioContentType to wav I am getting this error:

2021-11-09 12:27:36.841784 [DEBUG] lws_glue.cpp:84 (6) processIncomingMessage - unsupported audioContentType: wave

davehorton commented 2 years ago

Yes, this was a bug, but I think I fixed in the latest code (either wave or wav should work) https://github.com/drachtio/drachtio-freeswitch-modules/blob/4d9a4c4c6415524c6d22d3c21798766f803599d9/modules/mod_audio_fork/lws_glue.cpp#L79

egorsmkv commented 2 years ago

I am using drachtio/drachtio-freeswitch-mrf:v1.10.1-full, was this update included in that image?

davehorton commented 2 years ago

hmm, probably not. I will need to rebuild a newer image I guess

egorsmkv commented 2 years ago

Thank you, Dave

davehorton commented 2 years ago

can you try docker pull drachtio/drachtio-freeswitch-mrf:1.10.5 ?

I've just built this, it should have updated code and loads all the plugins. It uses Freeswitch 1.10.5

egorsmkv commented 2 years ago

Hello, Dave!

Sure, I will test this new version and let you know about my issue.

Thanks!

egorsmkv commented 2 years ago

Hello, Dave.

All is okay, I do not see the error message.

Thank you!