Open hhadzem opened 2 years ago
Hmm, I think you may be correct. It will be a few days or so before I can look further into it. If you have a solution, please post a PR. Thanks!
Thanks for the answer. I'll propose a solution (that you might find to be more of a hack, than a solution, but it does remove faulty connect gracefully), and post a PR.
why did you close the issue?
why did you close the issue?
Must have accidentally closed it. Sorry for inconvenience.
Hi Dave,
As it seems like, clearing pending connections does not work properly if the specified websocket is not valid.
The check given here
(*it)->m_wsi == wsi
is never true if the following line in processPendingConnects does not resolve websocket properly:ap->connect_client(vhd);
. More specifically,m_wsi = lws_client_connect_via_info(&i);
will result inm_wsi
beingnullptr
and will never equal towsi
parameter passed tolws_callback
.Can you confirm this is the expected behaviour and not a mistake on my behalf? Thanks in advance.