drachtio / drachtio-fsmrf

Drachtio freeswitch-based media resource function -- http://davehorton.github.io/drachtio-fsmrf
MIT License
47 stars 26 forks source link

conference.startRecording Crash #52

Closed lylepratt closed 2 years ago

lylepratt commented 2 years ago

Howdy Dave!

I've found that using conference.startRecording crashes due to this regex not properly handling the result. When I run it, I get a result like this:

Error: +OK Record file rtmp://XXX.YYY/ZZZ/05f7cda210ff4ea49122aea69ae595b3 canvas 1 Notice the +OK. That seems to trip up your regex which causes the crash.

Freeswitch does start recording the file, its just that FSMRF detects it as an error.

lylepratt commented 2 years ago

Ahh, I see that it's not actually the +OK its the canvas 1 clashing with the \n$ operator in your regex. Any chance you could update this?

lylepratt commented 2 years ago

This PR is working for me: https://github.com/drachtio/drachtio-fsmrf/pull/53