drachtio / drachtio-fsmrf

Drachtio freeswitch-based media resource function -- http://davehorton.github.io/drachtio-fsmrf
MIT License
47 stars 26 forks source link

feature request: enhancements to Endpoint#play method #62

Closed davehorton closed 1 year ago

davehorton commented 2 years ago

Currently, the Endpoint#play method takes either a single file (as a string) or an array of files (as an array). I would like to offer another possibility:

So for example, this would be possible:

ep.play({file: 'http://example.com/recording.wav, seekOffset: 7000});

If an object is passed it can have the following properties:

The method should then play the fill starting from the given offset.

This option is only available when playing a single file, not an array of files.

Furthermore, when the play is done we currently call the callback and pass back playbackSeconds and playbackMilliseconds to tell the caller how much of the call was played. This payload should be enhanced to include:

byoungdale commented 1 year ago

Hey @davehorton, I can work on this.

davehorton commented 1 year ago

great!

byoungdale commented 1 year ago

Actually, looks like this got implemented already back in august.

davehorton commented 1 year ago

ah right I forgot!

davehorton commented 1 year ago

published in 2.4.6