search

drachtio / drachtio-server

A SIP call processing server that can be controlled via nodejs applications
https://drachtio.org
MIT License
237 stars 92 forks source link

Update prometheus-cpp to v1.2.4 #288

Open orgads opened 1 year ago

xquanluu commented 1 year ago

Hi @orgads

It seem that we are wroking on same issue, could you please help me to review the PR from me: https://github.com/drachtio/drachtio-server/pull/287

I hope you can give me some comment to make it the best.

I'm still trying to fix CI failure there. It's great if you also can help me on that PR.

orgads commented 1 year ago

Which prometheus version did you checkout? I used tag v1.1.0. Build passes here (even without upgrading ubuntu): https://github.com/orgads/drachtio-server/actions/runs/5331207087

orgads commented 1 year ago

ping

orgads commented 1 year ago

@davehorton ping