Sign up - Githubissues

dracidoupe / graveyard

Open Source reimplementation of https://www.dracidoupe.cz/

https://nove.dracidoupe.cz/

MIT License

6 stars 4 forks source link

Sign up #134

Open jimmeak opened 3 years ago

jimmeak commented 3 years ago

Signing up should work (for now) as it use to at legacy web, but we still can adjust it a little bit.

[x] Sign up form via Django
[x] Graphical design for the form
[x] Admin needs to approve or cancel the registration
[ ] Track the first singing in and setting the password
[x] Email notifications
[ ] Add <noscript> version of the form

Almad commented 3 years ago

Thinking about #176, I think we actually may not want to use the Django signup form. I think it makes sense to use a separate model and only transfer the user into user/userprofile table upon approval.

The reason has to do with stuff like sending emails to all registered users, selectivity of the registered yes/no index and the amount of attributes in the user registration table that are just irrelevant during registration (and vice versa, like the questions for getting approved).

jimmeak commented 3 years ago

Something happened with registration. Now if someone wants to get sign up, this shows

Almad commented 3 years ago

Maybe it needs tests to prevent it from breaking 😏

Almad commented 3 years ago

Current bugs:

Signup complains about missing field without specification

If that happens, there is no way to confirm form again without going back and forth on the approval

Almad commented 3 years ago

It is possible to create registrations with an already existing nick