search

dracidoupe / graveyard

Open Source reimplementation of https://www.dracidoupe.cz/
https://nove.dracidoupe.cz/
MIT License
6 stars 4 forks source link

Compact list #359

Closed jimmeak closed 3 years ago

Almad commented 3 years ago

Skupiny are not working in some cases (like Articles or Warrior)

image

I'd also maybe add more creations per page in those cases 🤔

Almad commented 3 years ago

I think the singular idea doesn't make sense in this context, the correct name for the column is just "Name".

Or do you think the "Válečník" column above makes sense? IMHO it only goes for "Článek" in ČaE, somewhat.

jimmeak commented 3 years ago

I think the singular idea doesn't make sense in this context, the correct name for the column is just "Name".

Or do you think the "Válečník" column above makes sense? IMHO it only goes for "Článek" in ČaE, somewhat.

@Almad Of course, just like this it is not good, but I had the name before and e. g. Hřbitov is not very good either. That's why I wanted to make something more suitable exactly for this heading.

jimmeak commented 3 years ago

I just wonder—instead of doing template tag, wouldn't it be better to remove all -list templates and have one generic creations-list one? I don't think there is now something creation-specific left in all except (photo)gallery/download anyway, or is it?

I believe so, but I didn't want to destroy it all before asking first. :)

Almad commented 3 years ago

@jimmeak

I believe so, but I didn't want to destroy it all before asking first. :)

Nuke it from orbit! :)

Of course, just like this it is not good, but I had the name before and e. g. Hřbitov is not very good either. That's why I wanted to make something more suitable exactly for this heading.

How about "Jméno"? It also removes the need for singular, which I think doesn't make sense on the CreativePage model anyway—it should be on the particular Creations model.

jimmeak commented 3 years ago

How about "Jméno"? It also removes the need for singular, which I think doesn't make sense on the CreativePage model anyway—it should be on the particular Creations model.

I went for a "Název", it seems better for creations than name.

jimmeak commented 3 years ago

Nuke it from orbit! :)

Done, but it still will need some gallery and those special lists to edit, I think we have another issues for it (I believe for @Wynnka :smile: )

Almad commented 3 years ago

To be rebased & sent to master