Open lehkost opened 7 months ago
cmil
commented
7 months ago The header of the play is quite a complex thing. Which part of it should be right aligned? I don't think it makes sense to flip the entire header since the UI is still English and therefore left-to-right.
To give an idea of what I'm talking about, this is how the header looks if we put a dir="rtl" on its container:
Even if we adjust the margins and some sub element alignments, I'm not sure we should go that far.
lehkost
commented
6 months ago I think @sreyfe and @sinairusinek might be best to comment needs for the r-t-l header…
As for full-text view, I would add a general linebreak (and followed by an empty line) between "Direct print source:" and the <bibl> information. It will not mix up rtl and ltr text and also make for better readability for all corpora. We might not even need to put the bibliographic record in italics anymore.
sreyfe
commented
6 months ago I think it would be best for the whole header to be right-to-left. It reads strangely for the title to be all the way on the left... It's like if, in German or English, the title were all the way on the right. If we can get the spacing right, I think how it looks with an "rtl" on the div would look very good
sreyfe
commented
6 months ago did a bit of mock-up:
just changing some padding, changing direction to rtl and alignment to right. Still not perfect, but I think this looks much more natural for Yiddish
sreyfe
commented
6 months ago I think @sreyfe and @sinairusinek might be best to comment needs for the r-t-l header…
As for full-text view, I would add a general linebreak (and followed by an empty line) between "Direct print source:" and the
<bibl>information. It will not mix up rtl and ltr text and also make for better readability for all corpora. We might not even need to put the bibliographic record in italics anymore.
also agree with this^
at least in the case of Yiddish, where italics don't really exist...
sinairusinek
commented
6 months ago Hi there! So א וואדעוויל אין איין אקט is actually not bibl information but a sub heading. Did we mark it as Bibl?! I think the mock up version looks just right. There is also another solution which might look less odd to the non RTL reader - keeping the RTL but allign-center the entire block. But I still think this is way is exactly as I would expect it. If anything looks odd here it is the bottom menu (downloads to Network) which could definitely come on the left - or the center, since it is in English.
With the advent of the Yiddish Drama Corpus on our staging server we need to adjust the frontend a bit. First step could be a right-align of both the full-text display and the header for each play.