search

dracor-org / engdracor

English Drama Corpus
Other
0 stars 1 forks source link

updated JSONs #40

Closed lucagiovannini7 closed 2 years ago

lucagiovannini7 commented 2 years ago

Here is the first batch of JSONs created with the who-is tool.

lucagiovannini7 commented 2 years ago

Hello @cmil, before I go on preparing more plays for EPDraCor, is this first group of JSONs ok/could this PR be merged?

cmil commented 2 years ago

Hi @lucagiovannini7, I merged the PR even though there were a few errors in the JSON files. I fixed those in ca47e69f7f083f9a621691ac0cf6b01ea71982f6. I also regenerated the TEI files with the new JSONs. As you can see from the diff (017c005c2c66b29768bb2d156ee4e9eb1e4b366b) in several places who attributes got lost (e.g. https://github.com/dracor-org/epdracor/commit/017c005c2c66b29768bb2d156ee4e9eb1e4b366b#diff-4d46a13e93f5cb578b6f0927a006a9cdc106c2c21f7984dd797aea52f947e5f8R446). I created #41 to address this issue. We should also figure out how this happened and how we could improve epdracor-whois to avoid this.