Adjust header information - Githubissues

dracor-org / greekdracor

Ancient Greek plays from Perseus Digital Library

1 stars 3 forks source link

Adjust header information #6

Open lehkost opened 5 years ago

lehkost commented 5 years ago

[x] change publisher info to <publisher xml:id="dracor">DraCor</publisher>
[x] delete file name from <publicationStmt> (<idno type="URL">https://dracor.org/greek/xxxxx-xxxxx</idno>)
[x] remove meaningless subtitle <title type="sub">Machine readable text</title>
[x] change licence of digitalSource to CC by-sa just like in publicationStmt
[x] add date of first performance (probably from Wikidata, if available) – let's put the minus sign in front of years BCE (e.g., when="-408")
[ ] add gender information to all 440 characters

cmil commented 5 years ago

@lehkost Shouldn't we also remove these meaningless subtitles: <title type="sub">Machine readable text</title>?

nevmenandr commented 5 years ago

everything except for gender is done

lehkost commented 5 years ago

Great job! Seems to work fine, only thing is that the frontend has to be prepared to understand negative year numbers, right, @cmil!?

cmil commented 5 years ago

@lehkost In the other corpora the dates are put into the <bibl type="originalSource"> while in GreekDraCor they are now in <bibl type="digitalSource">, which is why the year is not picked up at all by the XQuery rendering the JSON.

cmil commented 5 years ago

I just made sure negative years get properly formatted in the frontend once they appear in the JSON. To make that happen, the dates should probably be moved to <bibl type="originalSource">.

nevmenandr commented 5 years ago

Done.