search

dracor-org / udracor

Ukrainian Drama Corpus (UDraCor)
2 stars 4 forks source link

adding four new plays to udracor #7

Closed DanilSko closed 1 year ago

DanilSko commented 2 years ago

all 4 files are missing a sourceDesc element

Added them here: https://github.com/dracor-org/udracor/pull/7/commits/9002b7844453e3ff6b251a5668cee3799e97c82e

Also, all TEI files in the repo are missing a publicationStmt

Added them to these fours plays here: https://github.com/dracor-org/udracor/pull/7/commits/702dbc8fdf79ba184a43a264850219df119353e2 Will add the rest publicationStmt-s in a separate PR

DanilSko commented 2 years ago

Ok, so I think the fixes are done @cmil

Would you perhaps find it helpful to add a validation workflow to udracor the same way I did for epdracor?

yes, I'd be happy!

cmil commented 1 year ago

Ok, so I think the fixes are done @cmil

It looks good, the new files validate against TEI_all now. Thanks!

Would you perhaps find it helpful to add a validation workflow to udracor the same way I did for epdracor?

yes, I'd be happy!

I will set it up then.

cmil commented 1 year ago

@DanilSko One last thing before merging: let's not add the tei/.DS_Store to git. We could add this file to .gitignore, but for Mac users it's also a good idea to add it to a .gitignore_global in their home directory. Mine looks like this:

*~
.DS_Store
.vscode
DanilSko commented 1 year ago

@DanilSko One last thing before merging: let's not add the tei/.DS_Store to git.

Ok done here! https://github.com/dracor-org/udracor/pull/7/commits/aefff60a04e4661284ff6c3eb93cbe1c47c453ba

for Mac users it's also a good idea to add it to a .gitignore_global in their home directory.

Done that too, thanks for the hint!

DanilSko commented 1 year ago

Ok @cmil I think it validates against TEI schema now: https://github.com/dracor-org/udracor/actions/runs/3312912149/jobs/5470177743 What do you think, shall we merge?

cmil commented 1 year ago

Ok @cmil I think it validates against TEI schema now: https://github.com/dracor-org/udracor/actions/runs/3312912149/jobs/5470177743 What do you think, shall we merge?

Yes, definitely. Great work!