search

dracula / base16-dracula-scheme

🧛🏻‍♂️ Dark theme for base16
https://draculatheme.com/base16
MIT License
32 stars 6 forks source link

Revert yellow/green swap #5

Closed m-dango closed 5 years ago

m-dango commented 5 years ago

The color names do not need to be strictly adhered to, as per the base16 page: "scheme designers should pick whichever colors they desire, e.g. base0B (green by default) could be replaced with red."

http://chriskempson.com/projects/base16/

Unfortunately, the swap of yellow/green has resulted in base16 no longer being consistent with the other Dracula themes. e.g. yellow is commonly used for strings in Dracula, which is base0B in base16.

mikebarkmin commented 5 years ago

Thank you for your pull request.

I have looked at many dracula themes and think you are right. We should revert the swap. By investigating the other themes I came to the conclusion that the other colors need some adjustments, therefore I created a new branch (development). Feel free to take a look and provide same feedback.

m-dango commented 5 years ago

Coincidentally I was doing something similar! Will take a look 🙂