search

dracula / base16-dracula-scheme

🧛🏻‍♂️ Dark theme for base16
https://draculatheme.com/base16
MIT License
32 stars 6 forks source link

Match Dracula Color Palette #8

Closed m-dango closed 5 years ago

m-dango commented 5 years ago

After some playing around with building this color scheme, I've come to realize that attempting to match syntax highlighting behavior with other Dracula themes is not a good way to approach this.

I've updated all the colors to match the descriptions with the main Dracula color palette, and included an extra color which was taken from the Atom theme.

mikebarkmin commented 5 years ago

Awesome. But I think we should swap green and yellow, as you have suggested in your first pull request.

m-dango commented 5 years ago

I disagree, as unfortunately my previous self was foolish! While it does help with consistency in syntax highlighting, it causes some oddities with highlighting elsewhere. For example, additions in git diff appear yellow instead of green if you're using base16-shell.

I going to investigate the possibility of adding a new feature for base16 builders, so that you can swap colors around for different applications. Since dracula already provides plenty of its own themes though, it shouldn't be an issue if that doesn't work out.

mikebarkmin commented 5 years ago

Ok, I have not considered the case of git diff. But I agree that an inserted block should appear in green. I guess we will never find a perfect fit, except we are going the route you mentioned and change the base16 builders. So sticking to the semantic meaning as defined in base-16 is our best options, I guess.

m-dango commented 5 years ago

I've just learned of the dracula spec. Going to leave my office and investigate some more later :)

m-dango commented 5 years ago

I've opened an issue to propose a new base16 builder feature, currently awaiting a response: https://github.com/chriskempson/base16/issues/179

mikebarkmin commented 5 years ago

Ok great. Let's wait what feedback you get.

actionless commented 5 years ago

i think you don't need to rely on the assumption what the proposal for template-specific will be accepted in a near feature

so as an alternative easy solution i recommend just shipping 2 (or more) YML files with dracula variants, for example like Gruvbox theme do

for example, dracula and dracula-terminal

mikebarkmin commented 5 years ago

@actionless Thank you for the suggestion. I think that could be the best way to handle this conflict.

belak commented 5 years ago

I can say that base16-shell has been a massive pain for me while maintaining the base16-emacs themes. It tends to override things that shouldn't be overridden and causes stuff to look slightly off in many cases.

Do the themes still look slightly messed up if you only use the terminal schemes and not base16-shell?