search

dracula / draculatheme.com

🧛🏻‍♂️ Dark website for a dark theme
https://draculatheme.com
201 stars 71 forks source link

Migration to Next.js #96

Closed zenorocha closed 4 years ago

zenorocha commented 4 years ago

Hello everyone,

We're migrating the site from Metalsmith to Next.js.

Before this goes live, we would like to get your feedback.

What problems are we solving with this release?

What problems are we not solving with this release?

Want to see for yourself?

Clone the 3.x branch and follow the instructions on the README.

If you're curious, you can see the full commit here: https://github.com/dracula/dracula.github.io/commit/46c42a7f46ae35684ed9e835e36a7c7108715d6c

@dracula/maintainers

benknoble commented 4 years ago

Just to clarify—not dynamically generated means the landing page only? The instructions will now be fetched from each repo, so, e.g., if (when) we update the vim instructions, the side will reflect that update?

Or will we still have to go through the process where we ask for a re-deploy to get the new instructions onto the site?

zenorocha commented 4 years ago

What I meant is that every theme page is dynamically generated (see [theme].js) and the landing page is hard-coded with each theme link.

In terms of the instructions being fetched from the repo, we would still need to go through a process of re-deploying the site :/

The GitHub API has a limit of requests (5000 per hour) and to avoid hitting this limit we would have the site static exported on build time.

oswaldoacauan commented 4 years ago

GitHub Actions to trigger a rebuild/deploy each time a PR is merged? 🙃

On Thu 26. Dec 2019 at 19:18, Zeno Rocha notifications@github.com wrote:

What I meant is that every theme page is dynamically generated (see [theme.js]) and the landing page is hard-coded with each theme link.

In terms of the instructions being fetched from the repo, we would still need to go through a process of updating the site :/

The GitHub API has a limit of requests (5000 per hour) and to avoid hitting this limit we would have the site static exported on build time.

— You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub https://github.com/dracula/dracula.github.io/issues/96?email_source=notifications&email_token=AAJVWJRJC5VPLTXN6MWUHH3Q2TYONA5CNFSM4J7LOILKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHV6G6Q#issuecomment-569107322, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJVWJS6OLPPA6R3PMKM6V3Q2TYONANCNFSM4J7LOILA .

zenorocha commented 4 years ago

I like that @oswaldoacauan!

benknoble commented 4 years ago

@oswaldoacauan yes please! Anything to avoid the discrepancy between a repo and the site; have the installation issues we get are because of this

zenorocha commented 4 years ago

Since you're all liking the current state, I deployed the 3.x branch to production so we can start feeling this new version for real.

zenorocha commented 4 years ago

Merged to site branch and now live on draculatheme.com.

benknoble commented 4 years ago

So, just to continue to clarify, I updated the vim screenshot, and draculatheme.com/vim has been updated with the correct screenshot. How did that happen? I didn't do it, that I'm aware of.

zenorocha commented 4 years ago

I made a deployment yesterday night. It was a coincidence, the automation has not been set up yet.

zenorocha commented 4 years ago

Ohh, I see that it was merged 3 hours ago, so let me clarify.

The screenshots are always fetched directly from the master branch, so regardless of deploying a new version of the site or not, it will always be the latest.

https://github.com/dracula/dracula.github.io/blob/site/pages/%5Btheme%5D.js#L42

Only the contributor list and the install instructions will depend on a new deployment of the site.