Region is yellow, with dark text

dracula / emacs

🧛🏻‍♂️ Dark theme for Emacs

https://draculatheme.com/emacs

MIT License

330 stars 87 forks source link

Region is yellow, with dark text #106

Closed dixius99 closed 2 months ago

dixius99 commented 2 months ago

Just testing out Dracula in Emacs (macOS, Emacs Plus), and noticed that the selected region is yellow, and the text is a single dark (black) colour. From the Dracula Syntax Highlighting Specification, and how selected text is handled in the VS Code theme, which is noted as a spec-compliant implementation of the theme, I was expecting the region to be closer to what I see in VS Code, with syntax highlighting for text otherwise staying the same. There's a design reason for this in the Emacs theme?

Emacs:

VS Code:

milouse commented 2 months ago

Historical reason only, and nobody complain until now.

I can try to check the feasibility of changing this highlighting color. I’m just afraid of https://www.xkcd.com/1172/ So probably I’ll keep the "old" behavior behind a variable?

dixius99 commented 2 months ago

I have to admit I have practically not experience with how Emacs themes work. I made a slight enhancement to the Catppuccin theme a while back, but that was more related to the TUI vs. the actual editor window.

By the way, I see that Catppuccin uses Dracula as a base. And for that theme, it looks like the region is more or less in line with what I figured it would look like in Dracula (a slightly lighter shade of grey, and the syntax highlighting retained).

milouse commented 2 months ago

I just pushed a fix. Can you test it and confirm it works for you too?

dixius99 commented 2 months ago

Wow, looks fantastic.