dracula / emacs

🧛🏻‍♂️ Dark theme for Emacs
https://draculatheme.com/emacs
MIT License
330 stars 87 forks source link

Adding faces for lsp-ui #64

Closed shpark closed 4 years ago

shpark commented 4 years ago

Screenshot from 2020-05-07 17-24-51

Some faces for lsp-ui (say 'lsp-ui-peek-highlight') are not defined, so IMO it doesn't look good.

It would be great if dracula provides some faces for lsp-mode users

milouse commented 4 years ago

I think you refer to https://github.com/emacs-lsp/lsp-mode, which I don't know at all. Can you annotate your screenshot to let me better understand where is the missing face, what is its purpose…

Don't hesitate to share several screenshot to help me figure out how the whole thing works.

milouse commented 4 years ago

I find all face declaration in that file. What is strange is that they all inherit from default faces, thus it should be already ok.

Wow ok, in fact you are speaking about https://github.com/emacs-lsp/lsp-ui, which hardcode a lot of new faces… It won't be easy to check that without using it.

If any user of it wants to contribute, don't hesitate to submit a PR :)