search

dracula / emacs

🧛🏻‍♂️ Dark theme for Emacs
https://draculatheme.com/emacs
MIT License
330 stars 87 forks source link

Add faces hardcoded by lsp-ui #65

Closed shpark closed 4 years ago

shpark commented 4 years ago

Screenshot from 2020-05-09 00-29-27

Add faces defined by lsp-ui-peek.el using existing colors.

Some faces defined in other files are not added yet.

This partially addresses #64.

milouse commented 4 years ago

Thanks a lot for your contribution. Can you ping me when you think this PR is ok to merge? Do you want to work more on it or it is sufficient for now?

shpark commented 4 years ago

To make this PR more complete, I am adding more faces from lsp-ui.

It contains pretty much all faces in that package, and IMO it is ready to be merged.

I attach a screenshot of lsp-ui-sideline FYI.

Screenshot from 2020-05-12 13-25-40

milouse commented 4 years ago

Looks good to me now. Would you mind to add a new screenshot to keep a reference of the expected result with the last color change? Then I'll merge it in master.

Thanks again for your contribution!

shpark commented 4 years ago

Screenshot from 2020-05-14 10-25-16

Thanks for reviewing the PR!

This screenshot shows the result of changing lsp-ui-peek-selection to match.

Current line is now in yellow background.

milouse commented 4 years ago

Merged as e375b6f2b7c07be0429c7fe0a9cbede8f2cf007a (I just rewrite your last commit).