search

dracula / emacs

🧛🏻‍♂️ Dark theme for Emacs
https://draculatheme.com/emacs
MIT License
327 stars 87 forks source link

Correct emacs-libvterm colors #76

Closed fernandodemorais-jf closed 3 years ago

fernandodemorais-jf commented 3 years ago

Actually, emacs-libvterm inherits Term colors, which is already configured. But, with no alterations to background of black color in dracula-theme.el Term settings, certain TUI programs display unreadable colors, like htop in VTerm:

image

If the line 694 of dracula-theme.el is changed to:

;; term
(term :foreground ,dracula-fg :background ,dracula-comment)

We'll have readable colors in TUI applications, such htop in VTerm:

image

P.S.: With this change, Term and VTerm colors will match others terminal emulators with Dracula Theme installed, as is the case of Konsole with Dracula Theme:

image

Thanks!

fernandodemorais-jf commented 3 years ago

Sorry @milouse,

I reported the wrong line in my original message. For the desired color correction, change in lines would be:

(term :foreground ,dracula-fg :background ,dracula-bg)
(term-color-black :foreground ,dracula-bg :background ,dracula-comment)

I only realize my error when I updated the theme through MELPA today. I was changed the term-color-black line in my local installation before.

Sorry once more.