dracula / emacs

🧛🏻‍♂️ Dark theme for Emacs
https://draculatheme.com/emacs
MIT License
330 stars 87 forks source link

Exchange the mode-line foreground #83

Closed dalugm closed 2 years ago

dalugm commented 3 years ago

The default active mode-line foreground is darker than the inactive mode-line, which may make it difficult for users to distinguish the current active buffer. After I exchanged these two values, it seems that the situation has been solved.

Here is the actual effort:

The left buffer is the current active buffer.

milouse commented 3 years ago

Thank you very much for your contribution.

The problem comes from the way your system pick a dark color for the "unspecified-fg" keyword. The current default behavior is as follow (active buffer left, inactive buffer right):

Capture du 2021-10-27 13-14-32

Normally both mode-line have the same kind of light foreground color, the only thing changing being the background.

Thus there are two problems:

I must admit I don’t use the default mode-line myself, but instead the dracula-alternate-mode-line-and-minibuffer one. I’ll see to change also the default setting to be most obvious of what is the active buffer.

milouse commented 3 years ago

Can you test my branch ed-fix-83 (commit 7c80ad7) and see if it’s better for you?

dalugm commented 3 years ago

your system pick a dark color for the "unspecified-fg" keyword

I see, it seems like my system's problem (I'm using macOS). Sorry for not considering users on other os.

After applying your fix, I believe this problem has been solved.

Here is the new screenshot (left is the active one):

fix
dalugm commented 3 years ago

And I think it might be better to set the mode-line-inactive's :background to dracula-bg, which is more readable:

(I changed the value of mode-line-inactive :background after applying your fix):

dracula-bg
dalugm commented 2 years ago

@milouse Any chance we could get your branch merged?

milouse commented 2 years ago

Yeah sorry, I was busy these days. I’ll try to do it this evening.