dracula / emacs

🧛🏻‍♂️ Dark theme for Emacs
https://draculatheme.com/emacs
MIT License
324 stars 86 forks source link

The icons in the breadcrumbs of lsp-mode cannot be displayed properly #95

Open xiaogaozi opened 1 year ago

xiaogaozi commented 1 year ago

The icons in the breadcrumbs of lsp-mode cannot be displayed properly, as shown in the following figure:

image

Expected

image

Current

It can be fixed by modifying the code in dracula-theme.el as follows:

;; Before
               (header-line :inherit 'mode-line)

;; After
               (header-line :background ,dracula-current
                            ;; :box ,dracula-current :inverse-video nil
                            ,@(if dracula-alternate-mode-line-and-minibuffer
                                  (list :foreground fg3)
                                (list :foreground dracula-fg)))

The version of dracula-theme I am using is 20220821.1717.

milouse commented 10 months ago

Hi,

Sorry for never coming back to you, and thank you for your detailed issue report.

One question comes to my mind though. From your test, what really fix the issue there: commenting (and so removing) the box and inverse-video setting from the face definition, or is it because currently header-line is declared before mode-line and maybe inherit from other things? Said otherwise, did you try to just move the header-line definition after the mode-line definition to see if it’s better?

Thank you very much for your precisions.