Turn this in the a FreeCAD Preference Pack

dracula / freecad

🧛🏻‍♂️ Dark Theme for FreeCAD

https://draculatheme.com/freecad

MIT License

33 stars 3 forks source link

Turn this in the a FreeCAD Preference Pack #2

Closed luzpaz closed 2 years ago

luzpaz commented 2 years ago

See https://github.com/Chrismettal/FreeCAD-Behave-Dark-Preference-Pack

Edit: FreeCAD-Behave was added to the Addon Manager (see https://github.com/FreeCAD/FreeCAD-addons/commit/0d23295401db40d413abf45818e6800c287868e0)

ref: https://github.com/FreeCAD/FreeCAD-addons/issues/201

eleanor-clifford commented 2 years ago

Hi @luzpaz, if you want to make this change I'd be happy to review a PR. Unfortunately I don't have the time to work on it right now.

luzpaz commented 2 years ago

Possibly. Can you add a 'Help Wanted' to this ticket JIC anyone else is inspired ?

Chrismettal commented 2 years ago

To turn this into a preference pack, don't we need to first include this stylesheet into FreeCADs source @luzpaz ?

If the stylesheet was packaged into FreeCAD I would like to wrap it into a Preference Pack, but I don't know what the current consensus is regarding getting "every" stylesheet into the FreeCAD source.

luzpaz commented 2 years ago

To turn this into a preference pack, don't we need to first include this stylesheet into FreeCADs source @luzpaz ?

I don't think so. Preference packs operate independently of core FreCAD, right @chennes ? (he's AFK till later this week)

Edit: reference: https://forum.freecadweb.org/viewtopic.php?f=8&t=58210

Chrismettal commented 2 years ago

That's how it worked for the Behave theme at least. The Preference pack chooses the already included stylesheet and sets all the colors not already set by the sheet.

I'm not sure if a preference pack alone is able to set all colors that the stylesheet usually sets.

luzpaz commented 2 years ago

Oh interesting. Didn't know that.

chennes commented 2 years ago

You can include the stylesheet withe the pack, it does not have to be part of the FreeCAD distribution.

Chrismettal commented 2 years ago

I have opened up PRs to refactor this repo into a PreferencePack, as well as distribute it with the internal addon manager.

You can try it out without merging by adding my fork to your FreeCADs addon manager custom repo list like this:

Searching for preference packs via the addon manager and installing the fork:

And lastly applying it from within preferences:

eleanor-clifford commented 2 years ago

closed by #3