search

dracula / google-chrome

🧛🏻‍♂️ Dark theme for Google Chrome
https://draculatheme.com/chrome
MIT License
66 stars 16 forks source link

Downloads banner color broken #12

Closed iam-cult closed 3 years ago

iam-cult commented 3 years ago

Upon updating my theme, I was greeted with a bright white downloads banner as shown below. This also affects the banner for installing themes. Screen Shot 2021-03-25 at 09 08 23 Screen Shot 2021-03-25 at 09 08 00

nickimola commented 3 years ago

Hi Gonna look into this as soon as I can. Thanks for reporting

iam-cult commented 3 years ago

Seems to also affect the icon that indicates a tab playing sound Screen Shot 2021-03-25 at 09 56 00

iam-cult commented 3 years ago

It seems like this stems from the removal of the "toolbar" value which was the fix to #11

nickimola commented 3 years ago

Yes it is, but keeping that value then created a thin gray line than breaks the group colouring (like per the #11 issue) I need to see if I can create images to use rather then colours for the download bar as well and wee what I can do for the icons

iam-cult commented 3 years ago

Yeah, would there be any way to make the gray line transparent, maybe through the "toolbar" value?

iam-cult commented 3 years ago

Did some searching around, and the color of these banners and icons seem to be non overwritable, being apparently based on the toolbar value. I know other themes that lack the gray line while still declaring a "toolbar" value, but I have no idea what invokes the line.

iam-cult commented 3 years ago

I set the "toolbar" value to [0, 0, 0] and it seemed to fix both the gray bar and the banner issue, but it's weird that the color you used would have somehow caused a bug

iam-cult commented 3 years ago

I've set it to [68, 71, 90] instead, which still fits the dracula colorscheme, and I will open a PR