dracula / google-chrome

🧛🏻‍♂️ Dark theme for Google Chrome
https://draculatheme.com/chrome
MIT License
66 stars 16 forks source link

add tab_line to accent the current tab #6

Closed vanmash closed 3 years ago

vanmash commented 3 years ago

With many open tabs it might be hard to see the current one. Adding tab_line should solve this.

nickimola commented 3 years ago

Hi Is this for windows or mac? I am using mac and I pulled your MR, but couldn't see any difference Can you please provide a screenshot? Thanks

bigpick commented 3 years ago

I agree with Nick. Editing the manifest locally and trying to update to use that (either through re-packaging or just using same theme and then deleting existing cache) doesn't have any effect.

From what I saw, it didn't seem like Google Chrome even supports the tab_line variable;

... which is a shame, since I quite like the additional but still minimal line that it provides. It doesn't seem that manifest v3 supports that feature, either (though that introduces Tab groups, which is a different thing; I also tested the latest Chrome Beta as well)

vanmash commented 3 years ago

Oh, well. It looked too easy. It should be possible. Minimal Rose has it. https://chrome.google.com/webstore/detail/minimal-rose/ljfbnpcobepdggjiheblpaenpmnjejob

Its manifest.json has such a section

       "images": {
            "theme_ntp_attribution": "images/theme_ntp_attribution.png",
            "theme_tab_background": "images/theme_tab_background.png",

            "theme_toolbar": "images/theme_toolbar.png",

            "theme_window_control_background": "images/theme_window_control_background.png"
        },
bigpick commented 3 years ago

Ah, I see. Yes, they use the images section and leverage the tiling of the specified image files there to get that effect it seems.

For example, I was able to replicate it locally using some things I drew up in Sketch real quick as a test:

Screen Shot 2021-02-07 at 10 06 27 AM

And then the resulting Chromium/Chrome tabs:

Screen Shot 2021-02-07 at 10 04 27 AM

... w/interaction:

dracula-tabs

Where the two sketch elements were exported as .pngs into the dracula theme's /images folder as

And then the manifest.json was updated to add

   "theme": {
      "colors": {
         ...
      },
      "images": {
         "theme_tab_background": "images/theme_tab_background.png",
         "theme_toolbar": "images/theme_toolbar.png"
      }

That's with a 5px tall accent bar, which imo is a tad too large; probably would look better with 2/3px instead.

bigpick commented 3 years ago

... with 2px tall accent:

dracula_tab

and

dracula-tabs

(re-uploaded w/the actual newest google-chrome theme colors)

nickimola commented 3 years ago

thanks, looks good! I will pack this tomorrow as soon as I can and release the update on the chrome web store