dracula / jetbrains

🧛🏻‍♂️ Dark theme for JetBrains IDEs (IntelliJ IDEA, PyCharm, RubyMine, PhpStorm, WebStorm, etc.)
https://draculatheme.com/jetbrains
MIT License
773 stars 36 forks source link

Theme deviation. #13

Closed blowsie closed 4 years ago

blowsie commented 4 years ago

Hi,

Thanks for your efforts in this theme! In the last update, the theme deviates alot from what I know, and love, and still find in other IDEs.

Example.

Webstorm:

image

VS Code:

image


Is this a bug? Why has the theme deviated?

WhiteVermouth commented 4 years ago
blowsie commented 4 years ago

Well, according to the dracula github some colors are well defined.

Palette Hex RGB HSL  
Background #282a36 40 42 54 231° 15% 18%  
Current Line #44475a 68 71 90 232° 14% 31%  
Selection #44475a 68 71 90 232° 14% 31%  
Foreground #f8f8f2 248 248 242 60° 30% 96%  
Comment #6272a4 98 114 164 225° 27% 51%  

I assumed this plugin was following these rules or there was some "official" way of defining how the theme looks.

Either way, personally I prefer how it looked before the update. Why? My method calls are more greyed out than my comments, which just seems backwards.

image

blowsie commented 4 years ago

So i did some digging and found many of the colors are not using the color pallette at all?

WhiteVermouth commented 4 years ago
  1. Comment color is not adopt from the palette. Because the original color may lead the comments hard to distinguish from others, see issue #1
  2. Exactly only two colors are not using the color palette:
    • Comment color, according to point 1.
    • Parameter color, due to color lackness in default palette.
  3. Any other colors not adopt from the official palette may be inherited from JetBrains IDEs' default color scheme.
  4. Other Dracula theme implementation keep some "pure white" syntax highlight like the one you see in VSCode port. I totally dislike this style, so I try to avoid such "pure white" color, which leads to this somewhat "deviated" implementation.