search

dracula / logseq

🧛🏻‍♂️ Dark theme for Logseq
https://draculatheme.com/logseq
MIT License
183 stars 58 forks source link

Fix five things #16

Closed fenilgmehta closed 1 year ago

fenilgmehta commented 1 year ago

Fixes https://github.com/dracula/logseq/issues/15

The color used is #1a1e24 Source: https://github.com/dracula/obsidian/blob/main/obsidian.css#L4

Before image image

After image image

  1. Absence of background color for line numbers in code block resulted in text overlap
  2. Added padding to scroll bar
  3. Made line number of active line brighter
  4. Another demonstration of point 2
  5. Background color added to "New page" button

Before image image image image

After image image image image

SlyBouhafs commented 1 year ago

Hey @fenilgmehta ! Thanks for the PR!

The background color for the inline code is a bit too dark and doesn't match the spec colors, i think it would look better if we use a color from the specs instead, would the light-background or the lighter-background colors work?

fenilgmehta commented 1 year ago

Yes, I understand that. Is it that the color used by the Obsidian Dracula theme (#1a1e24 source) not conformant with the original Dracula theme ?

light-background does not work as pointed in the below image image

lighter-background also does not seem to look good image

Using single color do not look pleasant since 4 different backgrounds are possible. Hence, updated the code to use different colors based on the background, and the screenshots too. Can you please check now.