dracula / slack

🧛🏻‍♂️ Dark theme for Slack
https://draculatheme.com/slack
MIT License
39 stars 11 forks source link

Support new Slack update #13

Closed asportnoy closed 7 months ago

asportnoy commented 10 months ago

Slack did a big re-design including with their theme system, so Dracula will need to be updated to work with that.

chessmango commented 10 months ago

I tried taking a stab at this, but it seems that there's explicitly a limited colour palette (for now?) Looking at Slack's FAQ it seems this is the 'new normal'.

The available colours, for what they're worth, are:

de4e2b

d65d30

e96825

cf6c02

d38d00

dea900

729c1a

379e15

2fa659

20a271

2392a2

0e9dd3

2985cd

4864d2

c474d3

c05b8c

ef3e75

f2606a

9c6c39

7c7a7f

asportnoy commented 10 months ago

Yeah I talked to Slack support about this. They removed the color picker, they removed a bunch of the options, and they removed the import button even though you can still share a theme. Thoroughly disappointed in this update. Unfortunately unless they change something I think Dracula Slack is dead 😕.

a4sr3s commented 9 months ago

Should have never rebooted slack... miss Dracula already. Hopefully they push an update to get this working again.

michxymi commented 8 months ago

I had a bit of a play with the updated slack client and get it closer to the original look.

The problem has to do with the expect string for theme formatting. The original theme had 8 values while with the current version 10 values are expected. So by adding two more values on the original string list, for example:

#282A36,#44475A,#44475A,#8BE9FD,#6272A4,#FFFFFF,#50FA7B,#FF5555,#44475A,#44475A

and paste it in Slack/Settings/Themes/Import Theme I get a similar look. Hopefully there is some documentation about what each value represents, otherwise I'll have to do some reverse engineering to work it out.

Once I'm happier with the way it looks I'll submit a PR to maintainers for review.

mrmeku commented 8 months ago

@michxymi You're my hero today

luxonauta commented 8 months ago

Can you make a PR for a test? 🤔

michxymi commented 8 months ago

Can you make a PR for a test? 🤔

Just made one. I haven't been able to exactly work out which colour values are mapping to which element so I opted to keep the greyish colour (#44475A, #44475A) as the two additional values required in the theme string. One thing that I don't see in comparison with the original is the electric blue highlight on the text but I haven't been able to fix that.

D-u-c-k-s-e-l commented 7 months ago

Digging into this issue, this was "fixed" two years ago (#8) by editing dracula.md to be the ten value color scheme. Unfortunately, this did not get applied to the instructions. I have created #15 which adds this to the instructions. It seems that the last two values correspond to the nav background and nav foreground (respectively).

quagliato commented 7 months ago

I have just merged @D-u-c-k-s-e-l's PR. The problem should be solved now.

Thank you all! :)