search

dracula / slack

🧛🏻‍♂️ Dark theme for Slack
https://draculatheme.com/slack
MIT License
39 stars 11 forks source link

Update for additional color choices #8

Closed KyleJamesWalker closed 3 years ago

KyleJamesWalker commented 3 years ago

Updating with the additional colors that are available within the latest version of slack.

The screenshot could also be updated, but I only have it work so I can't update the screenshot.

JimmyMultani commented 3 years ago

Hey @KyleJamesWalker, sorry for the late response.

I will check this out later tonight.

JimmyMultani commented 3 years ago

Hey @zenorocha, I don't have write access for this repo. Could we get this merged in please?

JimmyMultani commented 3 years ago

Hey again @zenorocha, could you please take a look at this when you get a chance?

JimmyMultani commented 3 years ago

Friendly ping to @heinst, @quagliato or @zenorocha.

Can we get this looked at please? If we're lacking maintainers, I can volunteer.

quagliato commented 3 years ago

Friendly ping to @heinst, @quagliato or @zenorocha.

Can we get this looked at please? If we're lacking maintainers, I can volunteer.

@JimmyMultani Hey, sorry for the delay. The notification about it got lost in my inbox. I'll check it later today and I'll update the screenshot also. About volunteering as a maintainer, maybe @zenorocha can give you the right permissions. :)

quagliato commented 3 years ago

@JimmyMultani @KyleJamesWalker Hey! I was reviewing this PR few minutes ago and I noticed that it changes the mention badge color from red to orange. I just tested this new option and I really don't like the orange badge with the white number in it:

Screen Shot 2021-05-30 at 16 25 30

Maybe we should use this PR just to add the colors to the new 3 options, keep the mention badge in red and discuss the change from red to orange in a new PR. WDYT?

JimmyMultani commented 3 years ago

Hey @quagliato, I think that's a fine idea!

@KyleJamesWalker, do you have time to update this PR? If not, we can address it ourselves.

KyleJamesWalker commented 3 years ago

Yeah I can take a look at the badge color shortly.

KyleJamesWalker commented 3 years ago

@quagliato are you sure you have the values from this PR?

Here's what it looks like for me: image

And here's what it looks like for a mention counter image

EDIT: Sorry I changed that locally on my setup, let me update it to what I've had for a while locally.