dracula / spec

🧛🏻‍♂️ RFC for a Dracula Theme specification
https://spec.draculatheme.com
MIT License
10 stars 3 forks source link

Specify line numbers #8

Open abrudz opened 3 years ago

abrudz commented 3 years ago

Implementations currently take all kinds of approaches to line numbers:

Since the Visual Studio Code implementation is fully compliant, I suspect that the correct choice is ( comment ).

dsifford commented 3 years ago

Valid concern. Curious what the community thinks would be the best option here.

bigpick commented 3 years ago

+1 for comment; looks like that's what's used for vim as well.

Playing around with the colors in vim a bit more, I'd say second best would be comment, but it seems to get harder to read (with my eyes at least) with some amount of transparency on a window (whereas comment seems to fair a bit better when transparency is involved; granted, depends on what you have in the background). Though, could also see the argument that per the spec, Current Line shouldn't show up in a language highlighting at all, so by making the line numbers that color, there shouldn't be any sort of overlap with language highlighting, which may cause less visual distraction.

No Transparency

Comment, non-italic ![Screen Shot 2021-04-28 at 3 23 27 PM](https://user-images.githubusercontent.com/9803299/116461092-d4b07800-a835-11eb-8ede-f4970ab2159f.png)
Comment, italic ![Screen Shot 2021-04-28 at 3 25 30 PM](https://user-images.githubusercontent.com/9803299/116461213-ff023580-a835-11eb-8cf4-69d66c76d940.png)
Current Line, non-italic ![Screen Shot 2021-04-28 at 3 24 57 PM](https://user-images.githubusercontent.com/9803299/116461150-ea25a200-a835-11eb-931e-5e49f99daf7c.png)
Current Line, italic ![Screen Shot 2021-04-28 at 3 22 52 PM](https://user-images.githubusercontent.com/9803299/116461025-be0a2100-a835-11eb-8ad4-3947dbc9ce64.png)

Some Transparency

Current Line, non-italic ![Screen Shot 2021-04-28 at 3 17 50 PM](https://user-images.githubusercontent.com/9803299/116460435-11c83a80-a835-11eb-813d-bc59488e978f.png)
Comment, italic ![Screen Shot 2021-04-28 at 3 18 50 PM](https://user-images.githubusercontent.com/9803299/116460440-12f96780-a835-11eb-8e5a-c1eb83dbf61d.png)
Current Line, non-italic ![Screen Shot 2021-04-28 at 3 18 11 PM](https://user-images.githubusercontent.com/9803299/116460450-142a9480-a835-11eb-8c23-472190adcba2.png)
Current Line, italic ![Screen Shot 2021-04-28 at 3 18 31 PM](https://user-images.githubusercontent.com/9803299/116460445-1391fe00-a835-11eb-8979-e81381800605.png)

... that said, I think I still prefer the low obtrusion but comparatively high legibility that comment provides despite also sharing with in-use colors. Whatever you do, please no background on foreground