dracula / steam

🧛🏻‍♂️ Dark theme for Steam
https://draculatheme.com/steam
MIT License
93 stars 14 forks source link

Theme not working on newest Steam Version #27

Closed PoorPocketsMcNewHold closed 2 years ago

PoorPocketsMcNewHold commented 3 years ago

image Quite the important number of information on this screenshot, but I'll describe it.

koplo199 commented 2 years ago

Not working at all with the latest Steam version :'(

EDIT : Ok it was because 5.css has been renamed to 6.css

Jetspectre commented 2 years ago

Hello, would this be fixed soon or is there any workaround until a PR is made?

tintinmaster commented 2 years ago

It looks like the current version is broken. It probably will not be fixed till after Christmas :disappointed:

Jetspectre commented 2 years ago

Thank you for the response, I wish you a Merry Christmas!

koplo199 commented 2 years ago

@Jetspectre As a workaround you can use my branch if you don't mind the main color being purple instead of the current pink :) There's also a fix included which apply the theme to the initial loading page ;)

PoorPocketsMcNewHold commented 2 years ago

@Jetspectre As a workaround you can use my branch if you don't mind the main color being purple instead of the current pink :) There's also a fix included which apply the theme to the initial loading page ;)

Would have been a better idea to push request your changes, minor the aesthetics ones which differ from the dracula colorscheme.

koplo199 commented 2 years ago

Would have been a better idea to push request your changes, minor the aesthetics ones which differ from the dracula colorscheme.

Sure, but I'm honestly too lazy to do it. The color change regarding the loading page isn't a color swap in the config, there are "handpicked" colors (as the steam logo originally have three shades of blue in it, replaced by the purple from the dracula colorscheme + one lighter and darker version of it to replicate the original behavior) and I'm not interested in doing that for the pink color.

Would have been even better to use scss and make use of lighten(), darken(), saturate() and desaturate() functions, which would make accent color swapping far easier, but same issue : too lazy unfortunately.

Minor note : my changes do not differ from the dracula colorscheme, it just swap the pink color accent to purple, which I could argue is the right one.

Jetspectre commented 2 years ago

@koplo199 Many thanks, love the purple!

tintinmaster commented 2 years ago

@koplo199 I really like your changes, especially the loading page. Purple looks very good, and I even think now it's better fitting as an accent colour. Therefore, I will happily merge the changes :vampire: .

Merry Christmas :christmas_tree:

koplo199 commented 2 years ago

@tintinmaster Awesome, I'm glad you like it!

Merry Christmas to you too :christmas_tree: