search

dracula / sublime

🧛🏻‍♂️ Dark theme for Sublime Text
https://draculatheme.com/sublime
MIT License
95 stars 26 forks source link

Highlight colour is too dim (in SublimeText) #16

Open zenorocha opened 6 years ago

zenorocha commented 6 years ago

@CottonEaster commented on Tue Oct 02 2018

Existing Theme?

Yes.

Consider fixing the issue yourself. That's the best way to contribute ;) I do not really have the knowledge to do that, I am afraid.

If that doesn't work, take a screenshot that shows the actual bug and mention the specific maintainer of your theme.

Screenshot (with the first of the two readonly lines selected/highlighted, believe it or not):

image

That is using, within Sublime, the Agila Dracula 'theme' and the Dracula Markdown 'colour scheme'. There's an 'Agila Dracula' colour scheme available too, but it doesn't change the highlighting from what I have pictured here.

Specific maintainer: none given on https://github.com/dracula/dracula-theme#team.

It seems to be (compare #156) that the selection colour needs to stand out a bit more.

facelessuser commented 4 years ago

I'm not sure this issue applies here to be honest. The Agila Theme uses it's own Dracula variant for Markdown that uses a line highlight that does not conform to the palette:

                <key>lineHighlight</key>
                <string>#3b4452</string>

This Sublime theme uses the appropriate color:

                <key>lineHighlight</key>
                <string>#44475a</string>

This doesn't appear to be the appropriate place for this issue either. I personally think it should be closed and/or moved to https://github.com/arvi/Agila-Theme.

If there is subjective opinion about Dracula's recommended line highlight, switching to .sublime-color-scheme will allow users to override any color to give them more contrast by creating a simple override, which would also make this issue moot.

Here we create a simple override in our User folder (this is based on my current .sublime-color-scheme variant.

OBwnR41Cgv

As long as the Sublime color scheme is using Dracula's recommended palette, I see no issues here. And if there are issues, migrating to the new color scheme format will give people plenty of flexibility to role their own variant to suit their needs if contrast is a problem.