Use original color for selected text

dracula / sumatra-pdf

🧛🏻‍♂️ Dark theme for Sumatra PDF

https://draculatheme.com/sumatra-pdf

MIT License

26 stars 4 forks source link

Use original color for selected text #4

Closed anujdeshpande closed 7 months ago

anujdeshpande commented 8 months ago

This is much better in terms of contrast and easier to find

If you're fixing a UI issue, make sure you take two screenshots. One that shows the actual bug and another that shows how you fixed it.

TheForgottened commented 8 months ago

Hi, would it be possible to provide said screenshots in the PR? For consistency sake,

anujdeshpande commented 7 months ago

@TheForgottened Sure thing!

First screenshot is with #BD93F9 i.e. Purple from the dracula spec
Second screenshot is with #F1FA8C i.e. Yellow from the dracula spec
Third screenshot is with #44475A i.e. Selection from the dracula spec

I think the first or second (i.e. Purple or Yellow) would be a much better option in terms of contrast than what we have right now with the Selection option.

TheForgottened commented 7 months ago

Thanks for your contribution, the code has now been merged to master :)