better battery indication for charging from AC

dracula / tmux

🧛🏻‍♂️ Dark theme for tmux

https://draculatheme.com/tmux

MIT License

660 stars 312 forks source link

better battery indication for charging from AC #280

Closed mamantoha closed 2 months ago

mamantoha commented 2 months ago

Follow-up to https://github.com/dracula/tmux/pull/276.

However, the icons for charging from AC have been replaced with a single-symbol icon instead of two symbols for better visibility.

Theoreticallyhugo commented 2 months ago

I like your idea, however it seems as if the new character is partially overlapping with the character that follows. have you checked that this doesn't cause weird overlapping when charging to 100%?

mamantoha commented 2 months ago

macOS: fully charged

Linux: charging

Linux: discharging

Theoreticallyhugo commented 2 months ago

awesome! any clue why linux has no percent symbol? seems like that needs fixing (not trying to say that it was you). if i could approve i would :D

mamantoha commented 2 months ago

The master branch is also missing the "%" symbol. I will prepare a fix in a separate PR.

Theoreticallyhugo commented 2 months ago

cool :D

mamantoha commented 2 months ago

https://github.com/dracula/tmux/pull/281

ethancedwards8 commented 2 months ago

Thank you so much!