dracula / tmux

🧛🏻‍♂️ Dark theme for tmux
https://draculatheme.com/tmux
MIT License
660 stars 312 forks source link

Add icon for AC mode #292

Closed fvincenzo closed 1 month ago

fvincenzo commented 2 months ago

If tmux theme is run on a desktop the battery space is empty. Restore the previous behavior displaying AC and an icon.

Theoreticallyhugo commented 2 months ago

heya mate, that sounds like a good idea. however, i'd love to see some configurability allowing users to use dracula without nerd-fonts too. while i prefer nerdfonts, i think being able to use it without them is important. (if youre not using a nerd-font symbol and its just github being unable to display it, i apologise and approve your changes)

fvincenzo commented 2 months ago

Hello,

thank you for your review.

Yes I am using nerd font and the battery plugin (even all the others) use nerd font symbols for everything. I am not sure I understand what you want me to do 😄

Apologize if it is me not getting the concept.

[Edit: I think I got the idea 👍]

Note: I improved the documentation and fixed a bug in the process.

Theoreticallyhugo commented 2 months ago

Awesome! in the process of writing more documentation for this plugin, im planning on including example configs for people with and without nerd-fonts. if you'd like, you can comment your preferred icon for the no-battery icon, and i'll put it in the docs.

Thanks a lot for your contribution :D

fvincenzo commented 2 months ago

My prefererred config with nerd font is:

set -g @dracula-no-battery-label " AC"

without:

set -g @dracula-no-battery-label "AC"

If you need help with anything let me know. I use the theme on daily basis, happy to contribute back if needed.

P.S. Let me know when you merge my changes so that I can switch back to the official repo (currently using my fork with the patches).

fvincenzo commented 1 month ago

Hello,

Is this patch ready to be merged? Or do I need to do anything else?

Thanks!

ethancedwards8 commented 1 month ago

You're good to go, thank you!