dracula / tmux

🧛🏻‍♂️ Dark theme for tmux
https://draculatheme.com/tmux
MIT License
657 stars 308 forks source link

Enhancement: Weather Module: Zip Code override #34

Open Sicnus opened 4 years ago

Sicnus commented 4 years ago

I'm having an issue with the weather applet. To me it seems the weather is being pulled from a city that's over 100 miles away from me? I see the code in ~/.tmux/plugins/tmux/scripts/weather.sh and I guess I could tweak that, but it'd be nice if I could simply put a zip code preference in my .tmux.conf file to override any magic IP location gathering bits:

set -g @dracula-show-weather 31211

Risks: Folks not in the US don't have zip codes.

Not really sure about alternatives internationally, but I'm sure someone has done this logic somewhere on plugins for different windowmanagers.

ethancedwards8 commented 4 years ago

I do believe #52 solves this issue? I just merged it. Try it out with the new weather module and we'll go from there.

abatilo commented 4 years ago

52 helps with international users but doesn't let you override location when IP geolocation isn't accurate. It'd still be nice if we could get this update.

ypicard commented 3 years ago

Yes I agree, this would definitely be appreciated. Using a VPN prevents this information being useful. Thanks!

pataquets commented 1 year ago

@Sicnus : Does the feature added on #141 solve your issue?