search

dracula / vim

🧛🏻‍♂️ Dark theme for Vim
https://draculatheme.com/vim
MIT License
1.32k stars 455 forks source link

WinBar highlight does not follow color scheme #237

Open fedorenchik opened 3 years ago

fedorenchik commented 3 years ago

What happened

WinBar hightight colors left as defaults.

What I expected to happen

WinBar highlight groups ToolbarLine and ToolbarButton set to colors matching dracula theme.

Screenshot

Screenshot from 2021-03-30 12-38-16

Machine Info

benknoble commented 3 years ago

Is this from a plugin? Where do the groups come from?

We can certainly add support for a plugin (?) or for something that's part of default vim; it's also possible to customize those colors yourself.

fedorenchik commented 3 years ago

This is part of default vim. WinBar can be added as:

nnoremenu WinBar.test :test

and works like menu.

benknoble commented 3 years ago

Apologies for the delay. I haven't given this much thought in terms of what colors are appropriate. Suggestions are welcome; perhaps @dsifford knows something about how we should style UI elements?

If you're keen on experimenting, :help dracula-customization makes a good starting point

dsifford commented 3 years ago

I'll be honest and say I've never heard of winbar or any of the nnoremenu commands so I'm not even sure where to start.

I tried entering @fedorenchik's example in a blank editor and nothing seemed to happen.

benknoble commented 3 years ago

@dsifford I think in non-gui vim you have to :runtime menu.vim, and then use :emenu <MenuName>.<item> to access the menu. In gvim, you have to not have M in guioptions. @fedorenchik are you using the toolbar also? On MacVim, the menu appears in the system's menu bar by default.

fedorenchik commented 3 years ago

Here's recording of how WinBars work: Peek 2021-04-05 22-35

fedorenchik commented 3 years ago

I use Linux GTK3 GUI, Vim 8.2.2601

fedorenchik commented 3 years ago

This also works in terminal, as long as terminal supports mouse.

fedorenchik commented 3 years ago

This is demonstration of WinBar in terminal vim clicking split button with mouse: Peek 2021-04-05 22-42

benknoble commented 3 years ago

As I said I don't have much thought on this, nor the time to dig in to it. If we don't have a suggestion for a generic UI element, than I would recommend @fedorenchik try some things and come back with a suggestion.

fedorenchik commented 3 years ago

@benknoble Sorry, I don't understand what you mean by 'generic UI element'? WinBar is similar to button toolbar, but can be attached to each window (and use "text" UI inside vim windows).

And what things you mean you recommend to try? If you mean real use case, there's vimspector (modern debugger for vim): https://github.com/puremourning/vimspector

Or you want me to send PR (should be pretty easy (add ToolbarLine and ToolbarButton highlights)) ?

benknoble commented 3 years ago

It's a button /shrug we have all kinds of spec for programming- and markdown- specific syntax items, but the UI stuff (line numbers, etc.) is a bit more ad-hoc.

Yes, I'm suggesting you try some different things from the colorscheme's palette for those buttons and send a PR (w/ screenshot).