search

dracula / vim

🧛🏻‍♂️ Dark theme for Vim
https://draculatheme.com/vim
MIT License
1.34k stars 455 forks source link

do not use green as high-contrast-diff bg color #293

Closed etorth closed 2 years ago

etorth commented 2 years ago

...since it hides selected text in changed lines.

Sorry first issue comes quickly. As following, the tracebitmap in line 950 get hidden because selected text also uses green bg-color.

I created the s:blue since it's not used for now. It should avoid any potential conflict with current all used color-configs.

without fix: 1

with fix: 2

benknoble commented 2 years ago

Oh darn, I didn't think about that.

Unfortunately introducing a new color is probably not an option, unless it convincingly fits in to the existing palette. More at https://spec.draculatheme.com.

Can you explain what you mean by "selected text"? I'm wondering if there's another way to avoid this.

etorth commented 2 years ago

Oh darn, I didn't think about that.

Unfortunately introducing a new color is probably not an option, unless it convincingly fits in to the existing palette. More at https://spec.draculatheme.com.

Can you explain what you mean by "selected text"? I'm wondering if there's another way to avoid this.

ok let me try to find a color from the existing palette.