search

dracula / vim

🧛🏻‍♂️ Dark theme for Vim
https://draculatheme.com/vim
MIT License
1.34k stars 455 forks source link

Update GitSignsDelete highlight group to always link to DraculaRed #307

Closed speelbarrow closed 1 year ago

speelbarrow commented 1 year ago

This is an add-on to the changes made in #306. Upon further usage I noticed that the gutter column used by the GitSigns plugin never uses the darker background that the GitDiffDelete highlight group uses.

GitSignsDelete (new in #306) was set to link to DraculaRed unless the user was in a GUI or had g:colorterm set true. However, in both of those cases the correct background to use still isn't that provided by GitDiffDelete.

I've updated the GitSignsDelete highlight group to always link to DraculaRed to keep it consistent with the background of the other signs as well as the column as a whole.

dsifford commented 1 year ago

Agree. Screenshot showing the differences would also be helpful for my understanding here.

speelbarrow commented 1 year ago

Before (when g:dracula_colorterm=1 or has(“gui”)): image

After (in all contexts): image

If you look at the images from #306 you’ll see that the latter image here matches the background of the GitSigns symbol when a line has been added/modified.

benknoble commented 1 year ago

I'm good to merge, I think. I'll wait another few days to give Derek a chance to weigh in, and I'll take silence for tacit approval.

dsifford commented 1 year ago

LGTM!

@benknoble I trust your judgement. Feel free to merge anything in the future that you feel is warranted!