search

dracula / vim

🧛🏻‍♂️ Dark theme for Vim
https://draculatheme.com/vim
MIT License
1.34k stars 454 forks source link

Dracula breaks in floating windows in neovim 0.10.0 #322

Closed aricursion closed 3 months ago

aricursion commented 5 months ago

What happened

Colorscheme is not applied to floating windows properly.

What I expected to happen

The dracula colorscheme is applied to floating windows

Screenshot

Unintended behavior: Screenshot_20240603_095513

Intended behavior: (nvim version 0.9.5)

Screenshot_20240603_095642

Machine Info

Additional Info

Colorschemes have been a known issue due to some changes in nvim 0.10.0 the "standard" fix for this is to :set colorscheme vim before loading the custom colorscheme. However, this does not fix the behavior.

benknoble commented 5 months ago

I know that something in colorschemes has been changed with 0.10.0, but it would be really helpful to know what changed in 0.10.0 to affect the floating or popup windows.

benknoble commented 5 months ago

There are a few bits in the release notes about Floating highlights, but I don't see any that jump out as part of the problem. Indeed, it seems more like syntax highlighting is not being applied correctly in your screenshot.

aricursion commented 5 months ago

Would syntax highlighting effect the background color which is also wrong?

benknoble commented 5 months ago

Would syntax highlighting effect the background color which is also wrong?

I noticed that, and I don't think so. But the other colors, while not correct, are Dracula colors. So that's confusing. What's needed is more information, essentially: I don't know what we need to do differently, and (since I use Vim, not Neovim), I don't personally have the bandwidth to figure it out.

You might ask the Neovim devs or user community if they know? Or maybe you could look at the commit history to see what touches this area of the code and get some ideas about fixes that we could make?