Closed scottming closed 4 months ago
@stnley or @I-Want-To-Believe is this in your wheel house? Maybe @dsifford ? I directed @scottming here hoping we could get some more eyes with better expertise on this.
Apparently it used to look as desired; @scottming if you have time to try bisecting this repo to see what changed, that would be helpful. It may have been a change in Vim or Neovim, though, in which case that won't find anything.
I believe the reason is https://github.com/neovim/neovim/pull/22382
When checking for special attribute support we use has('gui_running')
. This returns 0
and 1
when running neovim in TUI and GUI (nvim-qt) respectively.
Setting g:dracula_full_special_attrs_support = 1
appears to fix the issue, however the colors aren't displaying quite right on every terminal (foot doesn't work, kitty works). That could be unrelated, I'll test some more.
Kitty with g:dracula_full_special_attrs_support = 0
Kitty with g:dracula_full_special_attrs_support = 1
nvim-qt
@scottming could you try setting that variable and let me know if it works for you?
Sorry, I noticed you included you mentioned you're using alacritty. It appears to have the same issue foot has, the colors aren't quite right.
@stnley Yes, this configuration solves the problem. Thank you. This is the effect I wanted.
I can confirm that Alacritty's undercurl (when using let g:dracula_full_special_attrs_support = 1
) uses the syntax color of the underlying text, not the highlight color. I get a squiggle, though, not a solid bar. Thanks @stnley for taking a look!
What happened
I noticed that Dracula has some issues with the highlighting of diagnostics. When it receives a range, Dracula turns all the text within that range orange. Notice line 6 in the screenshot. This is very disruptive when editing code and has poor readability. Nowadays, almost all LSPs return diagnostics in real-time, and returning a range for an entire line is very common.
What I expected to happen
What I want is an effect like One Dark, where only the wavy underline is changed, instead of changing the color of all the text.
Machine Info
Vim type (
vim
/gvim
/neovim
):Vim version: nvim 0.10
OS: mac
Terminal/Terminal Emulator/VTE: alacritty 0.13
TERM
environment variable:Additional Info