search

dracula / visual-studio-code

🧛🏻‍♂️ Dark theme for Visual Studio Code
https://draculatheme.com/visual-studio-code
MIT License
786 stars 209 forks source link

Color in v2.22.2 looks brighter than v2.22.1 #165

Closed GoodbyeNJN closed 3 years ago

GoodbyeNJN commented 3 years ago

After upgrading to v2.22.2, the color scheme of the soft theme looks brighter. I don't know if this change is expected or unexpected. Screenshot below:

v2.22.1 v2.22.2

dsifford commented 3 years ago

Dupe of #163. This was intended. There was a bug in the build phase of the soft variant that caused comments to not actually receive any color specifications, which caused it to match the default comment color.

GoodbyeNJN commented 3 years ago

Thank you for your reply, but on my screen, not only did I observe the abnormal color in the comment part, but all other colors appeared brighter. Is this also intended? For example, in v2.22.2, the color of the string "4.17.5", the keyword "function", the keyword "RegExp" and the number "32" are all brighter than v2.22.1, which can be confirmed with a color picker.

dsifford commented 3 years ago

Bug fix might have introduced another bug. I'll check on this soon.