dracula / visual-studio-code

🧛🏻‍♂️ Dark theme for Visual Studio Code
https://draculatheme.com/visual-studio-code
MIT License
786 stars 209 forks source link

Replace screenshots with non-subpixel-renderedversions #192

Closed GeoMaciolek closed 3 years ago

GeoMaciolek commented 3 years ago

(There will be a pull-request momentarily; wanting to reference this issue # in my commit.)

The Problem

The excellent screenshot provided here has a minor issue - the computer that rendered it is set to use sub-pixel rendering - this is fine when viewed at normal sizes on typical desktop LCD displays, but does not scale well - see the attached images. There are "funky color fringes" around the edges. Is it important? Not really, but, I've done a replacement screenshot that addresses this.

Subpixel Rendered (the current screenshot)

screenshot-subpixel

Non-subpixel Rendered (the current screenshot)

screenshot-nosubpixel

Further Discussion

Future Options

It may make sense to try to switch our systems to the no-subpixel-rendering mode before taking screenshots! Also, is there a guide, beyond this discussion?

Creation Notes

Font appears to be Fira Code, size 16 - at least on my system! Please do double check that everything looks good, though!

dsifford commented 3 years ago

Fair enough! Making the change sounds fine to me.

Font appears to be Fira Code, size 16 - at least on my system! Please do double check that everything looks good, though!

The font used was Monaco, but that doesn't really matter to me. Any mono font is fine for demo purposes.