dracula / visual-studio-code

🧛🏻‍♂️ Dark theme for Visual Studio Code
https://draculatheme.com/visual-studio-code
MIT License
776 stars 208 forks source link

Color Change in Git Diff mode #242

Closed Anselmoo closed 1 month ago

Anselmoo commented 11 months ago

I am wondering if it will be technically possible and make sense to change the diff git colors of VSCode

image

to the proposed colors for:

dsifford commented 11 months ago

Not sure I understand the question here. What are you asking for specifically? What are the diff colors set as right now?

Anselmoo commented 11 months ago

Dear @dsifford Thank you very much for your quick answer, and sorry for the lack of clarity.

If you have unstaged changes, VSCode shows this as differences in the source control menu (image) like:

image

however comparing

with Kimbie Dark

image

with Monakai

image

It appears to me that the color scheme of Dracula is not very noticeable, even if it has already been specified.

https://github.com/dracula/visual-studio-code/blob/e475d548db27773fa0004b252c0a4701f187fb7e/src/dracula.yml#L258C1-L270

image

What are your thoughts?

dsifford commented 11 months ago

I don't find it personally very difficult to differentiate, but I'm biased here because I'm the one who originally set it 😅

If you have any specific suggestions here, feel free to let me know or open a PR.

That said.. Since the theme has gotten to a critical mass of users (~6MM installs), I try to not introduce any jarring changes if I can avoid it so as to not rock the boat too much with those who have gotten used to things as they are.

Anselmoo commented 11 months ago

Thx, consistency is the overall target, I will take a look and may set a draft, not a PR.

That said.. Since the theme has gotten to a critical mass of users (~6MM installs), I try to not introduce any jarring changes if I can avoid it so as to not rock the boat too much with those who have gotten used to things as they are.

I cannot agree more ...

luxonauta commented 1 month ago

(#253)