search

dracula / zed

🧛🏻‍♂️ Dark theme for Zed
MIT License
30 stars 1 forks source link

fix: less transparency #17

Closed lsunsi closed 1 month ago

lsunsi commented 1 month ago

I'm trying zed on linux (yay!) and immediately went for Dracula. I was a little confused about the transparency and the issue #16 made me thing it was not intentional.

I made some local changes locally in order to keep exploring, but I have no idea if they are (1) correct (2) complete and especially if (3) they don't cause any side effects for other configurations.

I'm opening this PR just to share that these improved my situation and might help someone else. I'd love to see this fixed upstream by an experienced maintainer :D

lsunsi commented 1 month ago

Other thing I noticed, when there's no tab open it's also fully transparent. I tried to ff the background transparency, but then it's just light purple when it probably should be a darker background pattern. I have no fix for this one for now, just wanted to mention.

lsunsi commented 1 month ago

Further, I'll say making just these changes is probably not good enough, because upon using it for a couple more hours I see that it does look a little weird. Maybe someone that understands about Dracula themes could make better changes and make this PR in the correct way, so I'll close it for now and keep my eyes peeled on the mentioned issue. Sorry for the confusion!